Options: Split out AMR to its own options provider #2986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This breaks out AMR into its own default options provider to specify default versions but also allow us to do things like specify default RESP later on.
mgravell
approved these changes
Jan 13, 2026
Collaborator
Author
|
@philon-msft Did we get a chance to test this? |
Collaborator
|
@NickCraver I pushed a couple changes. I tested OSS and AMR caches including those changes, and all looks good |
philon-msft
approved these changes
Jan 20, 2026
Collaborator
aaaand I broke a bunch of tests. Fixing... |
mgravell
approved these changes
Jan 27, 2026
Collaborator
|
@philon-msft are you happy for this to merge? I feel you're the code-owner of this area... |
Collaborator
|
@mgravell Yep I think we're good to merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks out AMR into its own default options provider to specify default versions but also allow us to do things like specify default RESP later on.
Tagging @philon-msft for test run on both.